fix: Use status instead of targetStatus in UpdateWorker. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikbekalp
force-pushed
the
karthikbekalp/rnTS2Status
branch
from
d4c513b
to
a2fb57d
Compare
Signed-off-by: Karthik Bekal Pattathana <pattatk@dev-dsk-pattatk-2b-68804932.us-west-2.amazon.com>
karthikbekalp
force-pushed
the
karthikbekalp/rnTS2Status
branch
from
a2fb57d
to
8abb05f
Compare
karthikbekalp
commented
Sep 13, 2023
| @@ -416,7 +416,10 @@ def _transition_to_stopping(self, timeout: timedelta) -> None: | |||
| given additional new tasks to work on. | |||
| """ | |||
| request = dict[str, Any]( | |||
| farmId=self._farm_id, fleetId=self._fleet_id, workerId=self._worker_id, state="STOPPING" | |||
There was a problem hiding this comment.
Not sure if this worked before and was not updated when undergoing renames from state to targetStatus earlier ...
AWS-Samuel
approved these changes
Sep 13, 2023
ddneilson
approved these changes
Sep 14, 2023
epmog
approved these changes
Sep 14, 2023
Closed
gmchale79
pushed a commit
that referenced
this pull request
Mar 11, 2024
Signed-off-by: Karthik Bekal Pattathana <pattatk@dev-dsk-pattatk-2b-68804932.us-west-2.amazon.com> Co-authored-by: Karthik Bekal Pattathana <pattatk@dev-dsk-pattatk-2b-68804932.us-west-2.amazon.com> Signed-off-by: Graeme McHale <gmchale@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this change is not ready to be merged
What was the problem/requirement? (What/Why)
UpdateWorker was updated to use the new 'status' field instead of 'targetStatus' in Deadline Cloud service. This is because UpdateWorker is a synchronous API i.e. the status updates are instantaneous. Hence, updating the worker agent to use the new field.
What was the solution? (How)
Renamed status from targetStatus.
What is the impact of this change?
The WA will use the new field and hence that allows Deadline Cloud to remove targetStatus field.
How was this change tested?
This is a rename so assuming that the unit tests will fail if there are any issues.
Is this a breaking change?
No